Update pylint to 2.16 #1042
Merged
Update pylint to 2.16 #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wshanks
force-pushed
the
pylint
branch
2 times, most recently
from
c1bc454
to
2d77f3e
Compare
coruscating
reviewed
Mar 20, 2023
.pylintrc
Outdated
| # Regular expression matching correct constant names | ||
| const-rgx=(([A-Z_][A-Z0-9_]*)|(__.*__))$ | ||
|
|
||
| # Naming hint for constant names | ||
| const-name-hint=(([A-Z_][A-Z0-9_]*)|(__.*__))$ | ||
|
|
||
| # Regular expression matching correct class names | ||
| class-rgx=[A-Z_][a-zA-Z0-9]+$ |
There was a problem hiding this comment.
Since pylint enforces PEP8 name conventions by default, do we need these custom regexes? Are there names we're using now that don't comply with PEP8?
There was a problem hiding this comment.
I think this is a case of generating the default pylintrc with pylint and then modifying it, so these custom regexes just match the pylint default. We can try removing more stuff from the file. I just removed what I did because pylint was complaining that those options were no longer valid.
pylint has changed some defaults and removed some checkers since version 2.7 to be more in line with things like black.
mtreinish
reviewed
Mar 20, 2023
coruscating
approved these changes
Mar 21, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change set updates pylint from 2.7 to 2.16. The code was modified to satsify new checks added to pylint between those versions. Obsolete settings were removed from the pylintrc file.
Details and comments
The old version of pylint produces false positives that were fixed in a later version than 2.7.